Make hosts sticky for valid attachments #368
Conversation
barmac
force-pushed
the
1078-attached-boundary-events-should-be-sticky
branch
2 times, most recently
from
0c67f73 to
242f23d
Compare
barmac
changed the title
|
@nikku I rewrote this PR so that it actually fixes the bpmn-js problem within diagram-js. Please feel free to leave your comments. |
This implements sticky attachers functionality.
nikku
force-pushed
the
1078-attached-boundary-events-should-be-sticky
branch
from
242f23d to
aec89d7
Compare
| var shape = shapes[0], | ||
| hostGfx; | ||
|
|
||
| if (shape.host) { |
There was a problem hiding this comment.
We offer the method Canvas#addMarker and Canvas#removeMarker to add temporary classes to an element. All related logic is also contained in both, Move and MovePreview.
From what it looked like the only thing that is missing is to reuse the logic is setting a valid hover target when starting the move operation. I've sketched that idea here.
Works fine in diagram-js, makes bpmn-js fail with two random test cases 😢.
I've spent way too much time today trying to dig into the root cause of these failures.
Let's keep this as is for now and see if we can improve things later!
delete-merged-branch
bot
deleted the
1078-attached-boundary-events-should-be-sticky
branch
|
Updated with minor changes, cf. aec89d7. |
The (potential) host's hit shape will now grow so that it gives a stickiness effect. When merged, this will fix bpmn-io/bpmn-js#1078.