Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

743 create connection preview #326

Merged
merged 3 commits into from
May 8, 2019
Merged

Conversation

barmac
Copy link
Member

@barmac barmac commented Apr 30, 2019

Related bpmn-io/bpmn-js#744

BREAKING CHANGES:

When appending a shape to existing element, the layouter will
receive a connection without waypoints, source, target and with
only { source, target } hints. Make sure your layouter handles
such case.

@ghost ghost assigned barmac Apr 30, 2019
@ghost ghost added the needs review Review pending label Apr 30, 2019
@barmac barmac force-pushed the 743-create-connection-preview branch 2 times, most recently from abc86fe to 6dc5eb1 Compare May 3, 2019 12:46
@barmac barmac changed the title WIP 743 create connection preview 743 create connection preview May 3, 2019
@barmac barmac requested a review from philippfromme May 3, 2019 13:16
@barmac barmac force-pushed the 743-create-connection-preview branch from 6dc5eb1 to 0bf6a73 Compare May 3, 2019 13:27
@barmac barmac force-pushed the 743-create-connection-preview branch from 0bf6a73 to ee0b6e6 Compare May 7, 2019 09:09
nikku added 3 commits May 7, 2019 17:01
Diagram will display connection preview when appending
a shape.

BREAKING CHANGES:

When appending a shape to existing element, the layouter will
receive a connection without waypoints, source, target and with
only { source, target } hints. Make sure your layouter handles
such case.
@barmac barmac force-pushed the 743-create-connection-preview branch from ee0b6e6 to 987cb65 Compare May 7, 2019 15:01
@barmac barmac mentioned this pull request May 7, 2019
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@merge-me merge-me bot merged commit 16a7047 into master May 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the 743-create-connection-preview branch May 8, 2019 12:59
@ghost ghost removed the needs review Review pending label May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants