Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1344 Integrate Grid Snapping - Part 1 #319

Merged
merged 4 commits into from
Apr 26, 2019
Merged

1344 Integrate Grid Snapping - Part 1 #319

merged 4 commits into from
Apr 26, 2019

Conversation

philippfromme
Copy link
Contributor

  • allow snapping create/move with offset
  • integrate auto resize
  • integrate space tool

Related to camunda/camunda-modeler#1344
Related to camunda/camunda-modeler#1348
Related to camunda/camunda-modeler#1349

@philippfromme philippfromme requested a review from nikku April 18, 2019 13:05
@ghost ghost assigned philippfromme Apr 18, 2019
@ghost ghost added the needs review Review pending label Apr 18, 2019
@philippfromme philippfromme mentioned this pull request Apr 18, 2019
Merged
@philippfromme philippfromme force-pushed the 1344-integrate-grid-snapping branch from 0de3367 to b762015 Compare April 18, 2019 13:16
nikku
nikku requested changes Apr 23, 2019
View reviewed changes
lib/features/auto-resize/AutoResize.js Show resolved Hide resolved
lib/features/grid-snapping/behavior/ResizeBehavior.js Outdated Show resolved Hide resolved
lib/features/grid-snapping/behavior/ResizeBehavior.js Outdated Show resolved Hide resolved
lib/features/grid-snapping/behavior/ResizeBehavior.js Outdated Show resolved Hide resolved
lib/features/grid-snapping/index.js Outdated Show resolved Hide resolved
@nikku nikku force-pushed the 1344-integrate-grid-snapping branch from b762015 to 72ddcf8 Compare April 23, 2019 13:53
@ghost ghost assigned nikku Apr 23, 2019
nikku
nikku previously requested changes Apr 23, 2019
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some additional 🍪 (s).

lib/features/auto-resize/AutoResize.js Outdated Show resolved Hide resolved
lib/features/auto-resize/AutoResize.js Outdated Show resolved Hide resolved
lib/features/auto-resize/AutoResize.js Outdated Show resolved Hide resolved
lib/features/auto-resize/AutoResize.js Show resolved Hide resolved
@philippfromme philippfromme force-pushed the 1344-integrate-grid-snapping branch from 72ddcf8 to f6f3440 Compare April 26, 2019 13:26
@philippfromme philippfromme requested a review from nikku April 26, 2019 13:27
@nikku nikku dismissed their stale review April 26, 2019 13:31

OUTDATED

@philippfromme philippfromme force-pushed the 1344-integrate-grid-snapping branch from f6f3440 to 757c5fb Compare April 26, 2019 13:32
@philippfromme philippfromme force-pushed the 1344-integrate-grid-snapping branch from 757c5fb to e0cde5d Compare April 26, 2019 13:40
nikku
nikku approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎢

@merge-me merge-me bot merged commit eca3244 into master Apr 26, 2019
@ghost ghost removed the needs review Review pending label Apr 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the 1344-integrate-grid-snapping branch April 26, 2019 18:03
This was referenced Apr 26, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

Assignees

@nikku nikku

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @nikku