Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(context-pad): fix scaling tests #283

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

barmac
Copy link
Member

@barmac barmac commented Oct 9, 2018

The tests introduced in #282 didn't actually run. This PR fixes the problem. Also, bootstrapDiagram call was moved so that it's not repeated in the scaling tests any more.

@ghost ghost assigned barmac Oct 9, 2018
@ghost ghost added the needs review Review pending label Oct 9, 2018
@barmac barmac requested a review from philippfromme October 9, 2018 07:58
* scaling tests are now actually run
@philippfromme philippfromme force-pushed the fix-context-pad-scaling-tests branch from a9708db to 7ddd5e0 Compare October 9, 2018 10:56
@ghost ghost assigned philippfromme Oct 9, 2018
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few changes. Tests are now running 🍰 .

@merge-me merge-me bot merged commit ae8adab into master Oct 9, 2018
@delete-merged-branch delete-merged-branch bot deleted the fix-context-pad-scaling-tests branch October 9, 2018 10:59
@ghost ghost removed the needs review Review pending label Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants