Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize collapsed element when it is expanded #287

Closed
barmac opened this issue Oct 11, 2018 · 0 comments · Fixed by #288
Closed

Resize collapsed element when it is expanded #287

barmac opened this issue Oct 11, 2018 · 0 comments · Fixed by #288
Assignees
@barmac

Comments

@barmac
Copy link
Member

barmac commented Oct 11, 2018

Describe the Bug

The collapsed element does not resize after expansion even if the children have bigger size than the element. Resizing of a collapsed element is handled by bpmn-js (see: https://github.com/bpmn-io/bpmn-js/blob/master/test/spec/features/modeling/behavior/ToggleElementCollapseBehaviourSpec.js#L389) instead of diagram-js.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Create a collapsed element with a child of bigger size than the parent.
  2. Expand the element.

Expected Behavior

The collapsed element should be resized.

Environment

  • Browser: Chrome 69
  • OS: MacOS Mojave
  • Library version: 2.6.1
@ghost ghost assigned barmac Oct 11, 2018
@ghost ghost added the in progress Currently worked on label Oct 11, 2018
barmac added a commit that referenced this issue Oct 11, 2018
@barmac
fix(auto-resize): resize collapsed element when it is expanded
c82dca0 
* AutoResize will now be activated whenever a collapsed element
  is expanded unless the auto resizing is explicitly deactivated

Closes #287
@barmac barmac mentioned this issue Oct 11, 2018
Merged
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Oct 11, 2018
barmac added a commit that referenced this issue Oct 11, 2018
@barmac
fix(auto-resize): resize collapsed element when it is expanded
c4c3b86 
* AutoResize will now be activated whenever a collapsed element
  is expanded unless the auto resizing is explicitly deactivated

Closes #287
barmac added a commit that referenced this issue Oct 16, 2018
@barmac
fix(auto-resize): run on child element resize
865da68 
AutoResize will be fired when a child element is resized
unless hints disallow it.

Closes #287
Closes #786
merge-me bot pushed a commit that referenced this issue Oct 18, 2018
@barmac @merge-me
fix(auto-resize): run on child element resize
a6ebfd8 
AutoResize will be fired when a child element is resized
unless hints disallow it.

Closes #287
Closes #786
@nikku nikku closed this as completed Oct 18, 2018
@ghost ghost removed the needs review Review pending label Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(auto-resize): resize collapsed element when it is expanded bpmn-io/diagram-js
2 participants
@nikku @barmac