Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging exposes sub-pixel coordinates #271

Closed
nikku opened this issue Aug 22, 2018 · 0 comments
Closed

Dragging exposes sub-pixel coordinates #271

nikku opened this issue Aug 22, 2018 · 0 comments
Assignees
@nikku
Labels
bug Something isn't working

Comments

@nikku
Copy link
Member

nikku commented Aug 22, 2018

As an observation, Dragging exposes sub-pixel coordinates when users initiate a drag operation while being zoomed out. This causes confusion in downstream consumers of drag events (cf. camunda/camunda-modeler#886).

We should emit drag events with pixel coordinates normalized to integral numbers to avoid this issue.
@nikku nikku added bug Something isn't working backlog Queued in backlog labels Aug 22, 2018
nikku added a commit that referenced this issue Aug 22, 2018
@nikku
chore(dragging): normalize coordinates to full pixels
559e6f9 
This ensures dragging emits events with full pixel coordinates only, as
we don't support sub-pixel positioning
anywhere anyway.

Closes #271
@ghost ghost assigned nikku Aug 22, 2018
@ghost ghost added in progress Currently worked on and removed backlog Queued in backlog labels Aug 22, 2018
This was referenced Aug 22, 2018
Closed
Merged
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Aug 22, 2018
nikku added a commit that referenced this issue Aug 22, 2018
@nikku
chore(dragging): normalize coordinates to full pixels
e9ae6ea 
This ensures dragging emits events with full pixel coordinates only, as
we don't support sub-pixel positioning
anywhere anyway.

Closes #271
@ghost ghost removed the needs review Review pending label Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikku