Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BaseViewer): swap canvas and project logo #2274

Merged
merged 2 commits into from
Jan 20, 2025
Merged

fix(BaseViewer): swap canvas and project logo #2274

merged 2 commits into from
Jan 20, 2025

Conversation

nikku
Copy link
Member

@nikku nikku commented Jan 17, 2025

Proposed Changes

Ensures that the canvas is first in the focus / accessibility hierarchy of the browser:

capture GkFwUK_optimized

Without the fix the browser would tab through the diagram like this:

bpmn.io logo
canvas

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@nikku nikku requested review from lmbateman, a team, philippfromme and abdul99ahad and removed request for a team January 17, 2025 19:18
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 17, 2025
@abdul99ahad
Copy link
Contributor

Jan-20-2025 12-34-00

I couldn't focus the canvas. Is there something I'm missing testing this?

@nikku
Copy link
Member Author

nikku commented Jan 20, 2025

@abdul99ahad did you npm install before? Canvas focus is only added in recent versions of the library.

nikku added 2 commits January 20, 2025 10:17
Ensures that the canvas is first in the focus / accessibility hierarchy
of the browser.
@nikku nikku merged commit 61c2651 into develop Jan 20, 2025
11 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 20, 2025
@nikku nikku deleted the canvas-first branch January 20, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants