Fix uprobe target resolution #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktormalik
force-pushed
the
uprobe-parser-fix
branch
2 times, most recently
from
8d58f81 to
b4c43ba
Compare
If both a PID and a path is specified for uprobe, symbols from /proc/PID/exe are used. On the other hand, if a shortname for a library is used (e.g. u:libc:*), then symbols from the library are used. This unifies the behaviour by: - using /proc/PID/exe only if no path is specified - otherwise the path (or library) that the user specified is used. See bpftrace#2065 for details.
viktormalik
force-pushed
the
uprobe-parser-fix
branch
from
b4c43ba to
149a573
Compare
fbs
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2065 as suggested in this comment by @fbs.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md