Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FromAsCasing warnings in container files #81

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

frobware
Copy link
Contributor

@frobware frobware commented Aug 1, 2024

This commit addresses the FromAsCasing warnings issued by Docker during the build process by ensuring that 'as' is converted to 'AS' in the FROM directives.

Warnings observed:

  • FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 5)

Reference: https://docs.docker.com/reference/build-checks/from-as-casing/

This commit addresses the FromAsCasing warnings issued by Docker during
the build process by ensuring that 'as' is converted to 'AS' in the FROM
directives.

Warnings observed:
- FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 5)

Reference: https://docs.docker.com/reference/build-checks/from-as-casing/

Signed-off-by: Andrew McDermott <[email protected]>
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.61%. Comparing base (73d472d) to head (02bb7c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   27.61%   27.61%           
=======================================
  Files          81       81           
  Lines        6999     6999           
=======================================
  Hits         1933     1933           
  Misses       4877     4877           
  Partials      189      189           
Flag Coverage Δ
unittests 27.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msherif1234
Copy link
Contributor

/LGTM thanks!!

@mergify mergify bot merged commit c596fe2 into bpfman:main Aug 1, 2024
20 checks passed
msherif1234 pushed a commit to msherif1234/bpfman-operator that referenced this pull request Nov 15, 2024
…/ocp-bpfman-operator-bundle

chore(deps): update ocp-bpfman-operator-bundle to 59d9e02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants