Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixess issues 995 and 2490 #2790

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

fe-cj
Copy link
Contributor

@fe-cj fe-cj commented Sep 23, 2024

Fixes issues #995 and #2490. They are both related to the drawing of the top border horizontal line of a table.

  • The problem with #995 was that the top horizontal line of the table was drawn before the beginUnbreakableBlock of the dontBreakRows property was executed, leaving the horizontal line orphan in case of a pabe break. This bug appeared when dontBreakRows is active, table has no headerRows, and first row of the table causes a page break.
  • The problem with #2490 was that it was drawing the top border of a table with no headersRow and no dontBreakRows before knowing if the flag skipOrphanePadding will be activated. skipOrphanePadding causes not to draw any piece of a row in the current page. That is why the drawing of the table top border of the table when it has no headerRows and no dontBreakRows, has been moved to the method endRow, where we know if skipOrphanePadding will be activated or not.

@liborm85 liborm85 merged commit 348f76d into bpampuch:master Sep 25, 2024
6 checks passed
@liborm85
Copy link
Collaborator

Merged. Thanks.

liborm85 added a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants