feat: improve error handling when a dependency is missing (#592)

Co-authored-by: boyum <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

action.yml

@@ -18,5 +18,5 @@ inputs:
     required: false
 
 runs:
-  using: node16
+  using: node20
   main: dist/index.js

demo/build_info/repos

@@ -1,10 +1,6 @@
-https://github.com/h5p/blob
-https://github.com/h5p/blob
-https://github.com/h5p/blob
-https://github.com/h5p/downloadify
 https://github.com/h5p/drop
-https://github.com/h5p/embeddedjs
-https://github.com/h5p/filesaver
+https://github.com/h5p/drop
+https://github.com/h5p/drop
 https://github.com/h5p/flowplayer
 https://github.com/h5p/font-awesome
 https://github.com/h5p/h5p-advanced-text
@@ -61,7 +57,7 @@ https://github.com/h5p/h5p-true-false.git
 https://github.com/h5p/h5p-twitter-user-feed.git
 https://github.com/h5p/h5p-video.git
 https://github.com/h5p/jquery-ui.git
-https://github.com/h5p/shepherd.git
+# https://github.com/h5p/shepherd.git
 https://github.com/h5p/tether.git
 https://github.com/NDLANO/h5p-chart.git
 https://github.com/NDLANO/h5p-drag-n-bar.git

package.json

@@ -1,6 +1,6 @@
 {
   "name": "pack-h5p-action",
-  "version": "1.0.1",
+  "version": "1.1.0",
   "description": "Pack a H5P content type and its dependencies to a .h5p file",
   "main": "lib/main.js",
   "scripts": {

src/main.ts

@@ -119,16 +119,29 @@ async function cloneDependencies(
     ...new Set(
       dependencyFile
         .split("\n")
-        .filter(dependencyName => dependencyName.trim().length > 0),
+        .filter(dependencyName => dependencyName.trim().length > 0)
+        .filter(dependencyName => !dependencyName.startsWith("#")),
     ),
   ];
 
-  info(`Dependencies: ${JSON.stringify(dependencies)}`);
+  info(`Dependencies: ${JSON.stringify(dependencies, null, 2)}`);
 
   return Promise.all(
     dependencies.map(async dependency =>
       exec(`git clone ${dependency}`, undefined, {
         cwd: rootDir,
+        // eslint-disable-next-line github/no-then
+      }).catch(async error => {
+        let errorMessage = `Failed to clone ${dependency}: ${error}`;
+
+        switch (error) {
+          case "Error: The process '/usr/bin/git' failed with exit code 128":
+            errorMessage = `Failed to clone ${dependency}: The repository is probably either deleted or private. ${error}`;
+            break;
+        }
+
+        setFailed(errorMessage);
+        return Promise.reject(error);
       }),
     ),
   );
@@ -138,7 +151,10 @@ async function npmBuildProject(projectPath: string): Promise<void> {
   const isNodeProject = fs.existsSync(`${projectPath}/package.json`);
   if (isNodeProject) {
     try {
+      info(`Installing dependencies in ${projectPath}`);
       await exec("npm install", undefined, { cwd: projectPath });
+
+      info(`Building project in ${projectPath}`);
       await exec("npm run build --if-present", undefined, {
         cwd: projectPath,
       });