Fix trial payment requirement and sync upstream #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few lines down `params[:id]` is used, however since it is not in the allowed params list it is not possible to take the code path to create a subscription with an existing param. This allows the ID param through.
…-param Allow user to pass in a subscription ID on create
…nvoice_status_when_paid change invoice status to paid when paid = true
…_suite Fix test suite
Added additional allowed_params to create_subscription for better testing: payment_settings trial_settings
…ption-allowed-params Add payment_settings, trial_settings to create_subscription allowed_params
init Github Actions flow * Added test status badge to README * use 2.6 as a minimum ruby version in Actions * remove Travis config * Fixed no implicit conversion of Range into Integer for ruby 2.6 * increased minimum ruby Version from 2.4 to 2.6
* upstream/master: Init Github Actions and remove Travis (stripe-ruby-mock#886) add payment_settings trial_settings to subscription allowed_params change invoice status to paid when paid = true remove puts add note (maybe this belongs in the wiki?) fix the test suite use progress formatting Allow user to pass in a customer ID on create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges latest from https://github.com/stripe-ruby-mock/stripe-ruby-mock and fixes issue with requiring payment when creating trial.