Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change listening interfaces #23

Merged
merged 3 commits into from
Jun 19, 2019
Merged

Change listening interfaces #23

merged 3 commits into from
Jun 19, 2019

Conversation

l4u23n7p
Copy link
Contributor

@l4u23n7p l4u23n7p commented Jun 18, 2019 •
edited
Loading

Changes

  • Change http server to listen on all interfaces
  • Change default host to main ip address
  • Add addHandler() function to centralize all http handlers

Related to #20

@l4u23n7p l4u23n7p added bug Something isn't working major Major issue or pull request pkg-agent Agent pkg issue or pull request labels Jun 18, 2019
@l4u23n7p l4u23n7p requested a review from itsabdessalam June 18, 2019 18:11
@itsabdessalam itsabdessalam merged commit 23abd08 into develop Jun 19, 2019
@l4u23n7p l4u23n7p deleted the update/listening-interfaces branch June 20, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsabdessalam itsabdessalam itsabdessalam approved these changes

Assignees
No one assigned
Labels
bug Something isn't working major Major issue or pull request pkg-agent Agent pkg issue or pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l4u23n7p @itsabdessalam