Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky counts a skipped unittest test as a failure #96

Closed
MagiMaster opened this issue Feb 22, 2016 · 1 comment
Closed

Flaky counts a skipped unittest test as a failure #96

MagiMaster opened this issue Feb 22, 2016 · 1 comment

Comments

@MagiMaster
Copy link

If a test is skipped via unittest.skip(), it's counted as a failure and rerun. (If it's skipped via pytest.mark.skipif, it seems to work fine.)

This causes the test to get reported multiple times (it's correctly reported as skipped each time in the xml), which causes problems with xdist again (trying to remove tests from the queue multiple times).
@MagiMaster
Copy link
Author

It seems like this is the same as issue #43.

Jeff-Meadows added a commit to Jeff-Meadows/flaky that referenced this issue Mar 15, 2016
@Jeff-Meadows
Don't retry @Skipped tests.
59ce6fd 
Fixes box#96, which is a regression on box#43.
When the py.test plugin was refactored in box#76, the logic to not
retry Skipped tests was accidentally removed. This commit restores the logic
and adds a test so that we won't regress on this again.
@Jeff-Meadows Jeff-Meadows mentioned this issue Mar 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MagiMaster