Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nodejs20): WEBAPP-30462 Node updated to 20 #1545

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

rafalmaksymiuk
Copy link
Contributor

@rafalmaksymiuk rafalmaksymiuk commented Mar 5, 2025

Updated project to work with Nodejs 20.

Bumped resolution of acorn to most recent as with node update it's older version stops working properly with optional chaining operators. The proper solution is to update Webpack to next version which should be handled in another task.

Removed IE 11 compatibility. Due to side effect, constructor mocks with arrow functions stopped working (were transcribed before).

@rafalmaksymiuk rafalmaksymiuk requested a review from a team as a code owner March 5, 2025 16:08
@loonskai
Copy link
Contributor

loonskai commented Mar 6, 2025

@rafalmaksymiuk looks like the commits lint has failed, I think the format should be different https://git.dev.box.net/Box/frontend/tree/master/commitlint#commit-message-format

Squashed commits:
[61bd8f1] WEBAPP-30462: Test fixes after removing IE11 polyfills
[2f16f33] WEBAPP-30462: Test fixes after removing IE11 polyfills
[d26565e] WEBAPP-30462: Node updated to 20
[b9a4bab] WEBAPP-30462: Node updated to 20
@rafalmaksymiuk rafalmaksymiuk changed the title Node 20 feat(nodejs20): WEBAPP-30462 Node updated to 20 Mar 6, 2025
@mergify mergify bot merged commit 37e7504 into box:master Mar 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants