Add user service management #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, merged to dev. Well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managing user authentication and session handling was previously scattered across components, making the codebase harder to maintain and extend. To address this, we introduced a generic
UserServiceclass to centralize all user-related logic, improving reusability, maintainability, and consistency in handling authentication.Key Updates
UserService.js: Consolidated user-related logic such as login, logout, session checks, token management, and user data access.Login.js: Replaced direct API calls withUserService.login(), improved error handling, and added toast notifications for user feedback.Dashboard.js: Streamlined session checks and logout functionality usingUserService, removed redundantlocalStoragecalls, and cleaned up unnecessary logging.