Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] Implement Simple Login Page in Web Frontend #269

Closed
1 task done
danzio19 opened this issue Oct 8, 2024 · 5 comments · Fixed by #286
Closed
1 task done

[FE] Implement Simple Login Page in Web Frontend #269

danzio19 opened this issue Oct 8, 2024 · 5 comments · Fixed by #286
Assignees
@mahmutbugramert
Labels
frontend issue related with frontend issue template This issue is generated using templates priority: medium Urgent issue workload: 2 issues that are requiring medium effort
Milestone
451 - Milestone 1

Comments

@danzio19
Copy link
Contributor

danzio19 commented Oct 8, 2024 •
edited by mahmutbugramert
Loading

Description

We need implement a simple version of our web app's login page. It will only have some input fields, and no actual login authorization logic.

Required Activities

  • Implement simple login page

Estimated Time

30 minutes

Deadline

14 Oct 2024

Reviewer

@Halil-Ibrahim-Kasapoglu
@danzio19 danzio19 added priority: medium Urgent issue workload: 2 issues that are requiring medium effort issue template This issue is generated using templates frontend issue related with frontend labels Oct 8, 2024
@danzio19 danzio19 added this to the 451 - Milestone 1 milestone Oct 8, 2024
@danzio19 danzio19 assigned danzio19 and mahmutbugramert and unassigned danzio19 Oct 8, 2024
@mahmutbugramert
Copy link
Contributor

I created a mock login page. Here is the branch.

@mahmutbugramert
Copy link
Contributor

Issue now is open to review @Halil-Ibrahim-Kasapoglu

@hikasap
Copy link
Contributor

hikasap commented Oct 18, 2024

Can you create a pull request as It will be easier for me to review what has changed.

@mahmutbugramert mahmutbugramert linked a pull request Oct 18, 2024 that will close this issue
Create a mock login page #286
Merged
@mahmutbugramert
Copy link
Contributor

A pull request is created and linked with this issue. You may see the changes clearly now.

@hikasap
Copy link
Contributor

hikasap commented Oct 18, 2024

I've reviewed and approved your PR, as everything looks good to me. I've listed a few minor suggestions in the PR discussion for you to check.

For future reference, I recommend following the commit standards outlined here.

I'll close the issue once your code is merged. 👍

hikasap added a commit that referenced this issue Oct 18, 2024
@hikasap
Merge pull request #286 from bounswe/feature/FE-login-draft
ca2bea8 
feat(frontend): add mock login page

- Created a mock login page with email and password input fields.
- Styled the page using `Login.css`.
- Closes #269: Implemented simple login page in the frontend.
@hikasap hikasap closed this as completed Oct 18, 2024
@mahmutbugramert mahmutbugramert changed the title Implement Simple Login Page in Web Frontend [FE] Implement Simple Login Page in Web Frontend Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahmutbugramert mahmutbugramert

Labels
frontend issue related with frontend issue template This issue is generated using templates priority: medium Urgent issue workload: 2 issues that are requiring medium effort
Projects
None yet
Milestone
451 - Milestone 1
Development

Successfully merging a pull request may close this issue.

Create a mock login page bounswe/bounswe2024group2
3 participants
@hikasap @danzio19 @mahmutbugramert