Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend Replace Alerts With Toasters #888

Merged
merged 7 commits into from
Nov 27, 2023
Merged

Frontend Replace Alerts With Toasters #888

merged 7 commits into from
Nov 27, 2023

Conversation

Ardakacd
Copy link
Contributor

@Ardakacd Ardakacd commented Nov 27, 2023 •
edited
Loading

I replace built in alerts with toasters. For this, I add react-toastify package to our project.

@Ardakacd Ardakacd added Priority: Medium Issues that are important but not critical, and can be worked on after higher priority issues. Type: Enhancement Issues that suggest improvements to existing features or functionality. Status: In Review Issues that are waiting for review and approval from others. Team: Frontend Issues related to frontend team labels Nov 27, 2023
@Ardakacd Ardakacd added this to the 2nd Milestone milestone Nov 27, 2023
@Ardakacd Ardakacd requested a review from AliBasarann November 27, 2023 15:56
@Ardakacd Ardakacd self-assigned this Nov 27, 2023
AliBasarann
AliBasarann approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@AliBasarann AliBasarann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes. Toasters work fine. I am merging.

@AliBasarann AliBasarann merged commit 71c477e into main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliBasarann AliBasarann AliBasarann approved these changes

Assignees

@Ardakacd Ardakacd

Labels
Priority: Medium Issues that are important but not critical, and can be worked on after higher priority issues. Status: In Review Issues that are waiting for review and approval from others. Team: Frontend Issues related to frontend team Type: Enhancement Issues that suggest improvements to existing features or functionality.
Projects
None yet
Milestone
2nd Milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ardakacd @AliBasarann