Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrays as query parameter fix (axios) #877

Merged
merged 1 commit into from
Nov 27, 2023
Merged

arrays as query parameter fix (axios) #877

merged 1 commit into from
Nov 27, 2023

Conversation

canuzdrn
Copy link
Contributor

  • Axios generates url like "...?tags[]=&tags[]=..." which shouldn't be the case in modern web standards
  • This PR includes some adjustments on Spring's Tomcat server to accept such query parameters also

@canuzdrn canuzdrn added Type: Enhancement Issues that suggest improvements to existing features or functionality. Team: Backend Issues related to backend team labels Nov 27, 2023
@canuzdrn canuzdrn self-assigned this Nov 27, 2023
zeynep-baydemir
zeynep-baydemir approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@zeynep-baydemir zeynep-baydemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for solving this problem, it seems okey.

@zeynep-baydemir zeynep-baydemir merged commit 17fed80 into main Nov 27, 2023
@canuzdrn canuzdrn deleted the backend/array-query-param-fix branch November 27, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeynep-baydemir zeynep-baydemir zeynep-baydemir approved these changes

Assignees

@canuzdrn canuzdrn

Labels
Team: Backend Issues related to backend team Type: Enhancement Issues that suggest improvements to existing features or functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canuzdrn @zeynep-baydemir