Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group/get and get-all join status return #828

Merged
merged 2 commits into from
Nov 23, 2023
Merged

group/get and get-all join status return #828

merged 2 commits into from
Nov 23, 2023

Conversation

UnalDeniz
Copy link
Contributor

Users should be able to see whether a group is joined or not from the group pages. This is the backend part of the related work.

@UnalDeniz UnalDeniz added Priority: Medium Issues that are important but not critical, and can be worked on after higher priority issues. Type: Enhancement Issues that suggest improvements to existing features or functionality. Status: In Review Issues that are waiting for review and approval from others. Team: Backend Issues related to backend team labels Nov 23, 2023
@UnalDeniz UnalDeniz self-assigned this Nov 23, 2023
@UnalDeniz UnalDeniz linked an issue Nov 23, 2023 that may be closed by this pull request
Returning join status for groups #827
Closed
zeynep-baydemir
zeynep-baydemir requested changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@zeynep-baydemir zeynep-baydemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use extractSubject function in jwtutil to take the email from token. Could you use that please

@UnalDeniz
Copy link
Contributor Author

I have made changes according to your recommendation. There were similar mistakes in other endpoints too, so I have also corrected them. Can you check it again @zeynep-baydemir ?

zeynep-baydemir
zeynep-baydemir approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@zeynep-baydemir zeynep-baydemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. Thank you for your work.

@zeynep-baydemir zeynep-baydemir merged commit 41e09f3 into main Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeynep-baydemir zeynep-baydemir zeynep-baydemir approved these changes

Assignees

@UnalDeniz UnalDeniz

Labels
Priority: Medium Issues that are important but not critical, and can be worked on after higher priority issues. Status: In Review Issues that are waiting for review and approval from others. Team: Backend Issues related to backend team Type: Enhancement Issues that suggest improvements to existing features or functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Returning join status for groups
2 participants
@UnalDeniz @zeynep-baydemir