authorization logic implemented #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halisbal
requested review from
zeynep-baydemir and
canuzdrn
and removed request for
zeynep-baydemir
|
everything seems fine to me, all the status codes and returned values. We also need to update our endpoints too after this functionality, good job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the authorization logic to our project. After this PR is merged, you can just use @AuthorizationRequired decorator to any Java Controller, the endpoint will automatically require the authorization token in the header. If not provided or token is expired or the owner of the token's account is deleted, it will return 401, 403 or 405 error to the client.