Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaderboard Implementation and Modal in Sign-Up page #633

Merged
merged 8 commits into from
Dec 25, 2023
Merged

Leaderboard Implementation and Modal in Sign-Up page #633

merged 8 commits into from
Dec 25, 2023

Conversation

AliNasra
Copy link
Contributor

I have implemented the Leaderboard and the necessary Modal. The terms have to be revised before merging, though.

@AliNasra AliNasra self-assigned this Dec 25, 2023
@AliNasra AliNasra added Status: In Review Waiting for reviewers response to changes. Type: Feature A new feature of the product, which has yet to be developed. Platform: Frontend Frontend related issues labels Dec 25, 2023
@AliNasra AliNasra requested a review from kutaysaran December 25, 2023 15:10
@AliNasra
Copy link
Contributor Author

There has been an issue with the sign-up page. Gotta solve it!

selinisik
selinisik approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@selinisik selinisik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated leaderboard looks good and tag select works as expected. Well done

@selinisik selinisik merged commit 6d9c891 into frontend/development Dec 25, 2023
@selinisik selinisik deleted the Leaderboard-Backend-Connection branch December 25, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selinisik selinisik selinisik approved these changes

@enfurars enfurars Awaiting requested review from enfurars

@kutaysaran kutaysaran Awaiting requested review from kutaysaran

Assignees

@AliNasra AliNasra

Labels
Platform: Frontend Frontend related issues Status: In Review Waiting for reviewers response to changes. Type: Feature A new feature of the product, which has yet to be developed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AliNasra @selinisik