Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend/feature/moderation final page #629

Merged
merged 6 commits into from
Dec 25, 2023
Merged

Frontend/feature/moderation final page #629

merged 6 commits into from
Dec 25, 2023

Conversation

selinisik
Copy link
Contributor

No description provided.

@AliNasra
Copy link
Contributor

AliNasra commented Dec 25, 2023 •
edited
Loading

The moderation page has been successfully implemented.
image
When I click on the send button, I receive an affirmative response from the backend. I believe that, as far as the Frontend team is concerned, the work is over though I recommend, if time is available, revisiting the CSS of the page. I believe it can be done better. For now, it is good to go given the circumstances.
image

@AliNasra
Copy link
Contributor

AliNasra commented Dec 25, 2023 •
edited
Loading

BTW, the logo is cool! I recall that Suzan Hoca, allegedly, found it flashy :)

AliNasra
AliNasra reviewed Dec 25, 2023
View reviewed changes
prediction-polls/frontend/src/Components/Modals/JuryModal.jsx
<div className={styles.juryRules}>
<p>Before proceeding to make a decision on the poll in question, please carefully review and agree to the following terms:</p>

<p><strong>1. Impartiality:</strong> I affirm that I have no personal or financial interest in the outcomes of this poll and that I have not participated in the poll. I commit to making an unbiased decision based solely on the poll's content and the evidence provided.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we have to revise this clause. In the backend implementation, the moderators can be voter-casters, too.

@AliNasra
Copy link
Contributor

There is a conflict ... gotta solve it
image

@selinisik selinisik merged commit adf5781 into frontend/development Dec 25, 2023
@selinisik selinisik deleted the frontend/feature/moderationFinalPage branch December 25, 2023 14:56
@selinisik selinisik linked an issue Dec 29, 2023 that may be closed by this pull request
Implement final page of moderation pages(Jury request) #563
Closed
@selinisik selinisik self-assigned this Dec 29, 2023
@selinisik selinisik added Type: Feature A new feature of the product, which has yet to be developed. Platform: Frontend Frontend related issues labels Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliNasra AliNasra AliNasra approved these changes

@enfurars enfurars Awaiting requested review from enfurars

Assignees

@selinisik selinisik

Labels
Platform: Frontend Frontend related issues Type: Feature A new feature of the product, which has yet to be developed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement final page of moderation pages(Jury request)
2 participants
@selinisik @AliNasra