-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend/feature/poll closing & grading #614
Backend/feature/poll closing & grading #614
Conversation
…grading Continuous poll grading
…anup Jury request cleanup
Reward domain point
// | ||
} | ||
|
||
cron.schedule('*/60 * * * * *', closeFinishedPolls); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this work? https://www.npmjs.com/package/node-cron#allowed-values says allowed values are 0-59. If it works keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to discuss the routine time intervals with you so they are open to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, check my comment in pollCloseRoutine.js, then I can approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Batu! The period of activating changes might be changed later. Other than that, the queries are good and running. Tested some of them on SQLite server!
This pr implements the close Poll routine and adds poll closing and grading mechanics for discrete polls and continuous poll. Also domain points are updated according to poll grading implemented.