Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend/feature/poll closing & grading #614

Merged

Conversation

EmreBatuhan
Copy link
Contributor

This pr implements the close Poll routine and adds poll closing and grading mechanics for discrete polls and continuous poll. Also domain points are updated according to poll grading implemented.

@EmreBatuhan EmreBatuhan added Priority: High Serious problem that could block progress. Type: Feature A new feature of the product, which has yet to be developed. Platform: Backend Backend related issues labels Dec 23, 2023
//
}

cron.schedule('*/60 * * * * *', closeFinishedPolls);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work? https://www.npmjs.com/package/node-cron#allowed-values says allowed values are 0-59. If it works keep it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to discuss the routine time intervals with you so they are open to change

Copy link
Contributor

@Sefik-Palazoglu Sefik-Palazoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, check my comment in pollCloseRoutine.js, then I can approve.

Copy link
Contributor

@Sefik-Palazoglu Sefik-Palazoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@AliNasra AliNasra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Batu! The period of activating changes might be changed later. Other than that, the queries are good and running. Tested some of them on SQLite server!

@EmreBatuhan EmreBatuhan merged commit a4b6df0 into backend/development Dec 23, 2023
@EmreBatuhan EmreBatuhan linked an issue Dec 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Backend Backend related issues Priority: High Serious problem that could block progress. Type: Feature A new feature of the product, which has yet to be developed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poll Grading and Closing System
3 participants