Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Profile for Mobile App #578

Merged
merged 6 commits into from
Dec 19, 2023

Conversation

aemresafak
Copy link
Contributor

I have implemented the edit profile screen, albeit being late for a week. I am very sorry about the delay. This PR concludes #512. Now users can edit their profiles.

@aemresafak aemresafak added Priority: High Serious problem that could block progress. Status: In Review Waiting for reviewers response to changes. Platform: Android Android related issues. labels Dec 18, 2023
@aemresafak aemresafak self-assigned this Dec 18, 2023
Copy link
Contributor

@YigitSekerci YigitSekerci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI seems good in overall but you should connect this page to the backend. The backend is already implemented.

@aemresafak
Copy link
Contributor Author

can you check again please yigit?

Copy link
Contributor

@YigitSekerci YigitSekerci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helal Ahmettt devamkee

Comment on lines +8 to +13
/*
"points": 0,
"biography": "string",
"birthday": "string",
"isHidden": 0
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch Ahmet

@YigitSekerci YigitSekerci merged commit 390b25b into mobile/development Dec 19, 2023
@YigitSekerci YigitSekerci deleted the mobile/feature/edit-profile branch December 19, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Android Android related issues. Priority: High Serious problem that could block progress. Status: In Review Waiting for reviewers response to changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants