Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotation UI #572

Merged
merged 11 commits into from
Dec 19, 2023
Merged

Annotation UI #572

merged 11 commits into from
Dec 19, 2023

Conversation

AliNasra
Copy link
Contributor

The updated Implementation of the Annotation UI
Sample: View Annotation -> Click on Maverics from the annotations list:
image

@AliNasra AliNasra self-assigned this Dec 16, 2023
This was linked to issues Dec 16, 2023
Annotation: UI Research and implementation #493
Closed
Fixing the annotation approach #543
Closed
@AliNasra
Copy link
Contributor Author

This is the final implementation. A user can now:
1- See his/her own annotations
2- See All the annotations
3- Hide the annotations all together!
image

@AliNasra
Copy link
Contributor Author

The backend has been integrated successfully, too!

enfurars
enfurars approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@enfurars enfurars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI looks nice and compatible with the subjects we learned. Well done Ali!

@AliNasra AliNasra added Type: Feature A new feature of the product, which has yet to be developed. Platform: Frontend Frontend related issues labels Dec 19, 2023
@AliNasra
Copy link
Contributor Author

Thanks for your review, Enes!
I have updated the code such that the annotation list is retrieved given that the response is an object with an "annotations" feature.

@AliNasra AliNasra merged commit fe917eb into frontend/development Dec 19, 2023
This was referenced Dec 19, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enfurars enfurars enfurars approved these changes

@selinisik selinisik Awaiting requested review from selinisik

@kutaysaran kutaysaran Awaiting requested review from kutaysaran

Assignees

@AliNasra AliNasra

Labels
Platform: Frontend Frontend related issues Type: Feature A new feature of the product, which has yet to be developed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixing the annotation approach Annotation: UI Research and implementation
2 participants
@AliNasra @enfurars