Notifications Page #428
Merged
Notifications Page #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
is it done? |
Closed
yup |
|
it is ok for now. can be further improved because it is lack of necessary information, urgency and probably time created. Those will be necessary and vital at real scenario. |
…ications-page # Conflicts: # resq/frontend/src/App.js
add folders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #419 by implementing the UI for the notifications page and the notifications icon that displays number of unread notifications on the top bar with mock data. We are waiting on mobile's implementation of push notifications for implementing web push notifications and hooking this up to the backend.
The page looks like this:
You dismiss a notification by clicking on it. Then, it looks like this: