-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/296 design api for responder functionalities #304
Merged
alitpc25
merged 13 commits into
dev
from
feature/296-Design-API-for-responder-functionalities
Oct 29, 2023
Merged
Feature/296 design api for responder functionalities #304
alitpc25
merged 13 commits into
dev
from
feature/296-Design-API-for-responder-functionalities
Oct 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RequestMapping changed from "action" to "/action" Also, @RequestParam and @PathVariable used for different conventions. /viewActions?taskId= is better. Here, taskId is request param. If we need to view action by its id, then it is better to use @PathVariable like this "/viewAction/{id}". Here, id is path variable.
viewActions endpoint can be used by both responders and coordinators.
@PreAuthorize("hasRole('RESPONDER') or hasRole('COORDINATOR')") should be used in controller layer, not in service layer.
In the create task request, some fields may be null initially
alitpc25
reviewed
Oct 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Some points are changed.
kubraaksux
deleted the
feature/296-Design-API-for-responder-functionalities
branch
December 19, 2023 20:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation task, accepting task, viewing action, viewing tasks, viewing actions implemented. There could be modifications as client may want to change endpoints.