Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/296 design api for responder functionalities #304

Merged
merged 13 commits into from
Oct 29, 2023

Conversation

furknbulbul
Copy link
Contributor

Creation task, accepting task, viewing action, viewing tasks, viewing actions implemented. There could be modifications as client may want to change endpoints.

@furknbulbul furknbulbul requested a review from alitpc25 October 29, 2023 12:28
@alitpc25 alitpc25 self-assigned this Oct 29, 2023
RequestMapping changed from "action" to "/action"

Also, @RequestParam and @PathVariable used for different conventions. /viewActions?taskId= is better. Here, taskId is request param.

If we need to view action by its id, then it is better to use @PathVariable like this "/viewAction/{id}". Here, id is path variable.
viewActions endpoint can be used by both responders and coordinators.
@PreAuthorize("hasRole('RESPONDER') or hasRole('COORDINATOR')") should be used in controller layer, not in service layer.
In the create task request, some fields may be null initially
Copy link
Contributor

@alitpc25 alitpc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Some points are changed.

@alitpc25 alitpc25 reopened this Oct 29, 2023
@alitpc25 alitpc25 merged commit 5efcea7 into dev Oct 29, 2023
@kubraaksux kubraaksux deleted the feature/296-Design-API-for-responder-functionalities branch December 19, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants