Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation api #195

Merged
merged 5 commits into from
May 12, 2023
Merged

Translation api #195

merged 5 commits into from
May 12, 2023

Conversation

volcaniqueo
Copy link
Contributor

@volcaniqueo volcaniqueo commented May 12, 2023 •
edited
Loading

I implemented Google Translation API.

@volcaniqueo volcaniqueo added the API API label May 12, 2023
@volcaniqueo volcaniqueo added this to the Practice Application milestone May 12, 2023
@volcaniqueo
Copy link
Contributor Author

will resolve the conflicts and open again

@volcaniqueo volcaniqueo reopened this May 12, 2023
@volcaniqueo
Copy link
Contributor Author

All fine, ready to merge!

@alperenDagi alperenDagi self-requested a review May 12, 2023 11:34
alperenDagi
alperenDagi requested changes May 12, 2023
View reviewed changes
Copy link
Contributor

@alperenDagi alperenDagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still contains conflict in App.js. Please resolve it manually.

@alperenDagi alperenDagi merged commit 716c8ed into dev May 12, 2023
@volcaniqueo
Copy link
Contributor Author

Still contains conflict in App.js. Please resolve it manually.

I resolved it. Problem was that Imbd Api has also been included to dev branch after I sent the request. Thank you!

@alitpc25 alitpc25 deleted the translation-api branch October 12, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperenDagi alperenDagi alperenDagi requested changes

Assignees
No one assigned
Labels
API API
Projects
None yet
Milestone
Practice Application
Development

Successfully merging this pull request may close these issues.
2 participants
@volcaniqueo @alperenDagi