Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imdb api #172

Merged
merged 5 commits into from
May 10, 2023
Merged

Imdb api #172

merged 5 commits into from
May 10, 2023

Conversation

furknbulbul
Copy link
Contributor

No description provided.

@furknbulbul furknbulbul requested a review from alperenDagi May 10, 2023 19:25
alperenDagi
alperenDagi approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@alperenDagi alperenDagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One possible improvement could be to add more specific error handling for certain cases instead of just returning a generic INTERNAL_SERVER_ERROR. For example, if the query parameter is missing, you could return a BAD_REQUEST status.

@alperenDagi alperenDagi merged commit 12d5d26 into dev May 10, 2023
@alitpc25 alitpc25 deleted the imdb-api branch October 12, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperenDagi alperenDagi alperenDagi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@furknbulbul @alperenDagi