Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twoliter: fetch instead of fetch-sdk for builds #223

Merged
merged 1 commit into from
May 17, 2024

Conversation

webern
Copy link
Contributor

@webern webern commented May 17, 2024

Issue number:

Fixes #214

Description of changes:

We accidentally removed "fetch" from the Makefile.toml dependency graph when building a variant. This change restores it.

Get fetch back into the dependency graph for build-variant and build-package.

Testing done:

  • Before this fix I would get an error during go mod vendor and could see that fetch-vendored was not running.
  • After this fix, Bottlerocket builds.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

We accidentally removed "fetch" from the Makefile.toml dependency graph
when building a variant. This change restores it.
@webern webern marked this pull request as ready for review May 17, 2024 00:19
@webern webern merged commit bec2a5c into bottlerocket-os:develop May 17, 2024
1 check passed
@webern webern deleted the fix-fetch branch May 17, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants