Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust dependencies #1196

Merged
merged 5 commits into from
Nov 6, 2020
Merged

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Nov 5, 2020

Description of changes:

b5fe2438 Update Rust dependencies in tools/
c1b02559 Remove no-longer-used 'rand' dep from update_metadata
7449ff6a Remove unused 'migrator' dep from updog
7106cc70 Remove no-longer-used 'futures' dep from apiclient
01248d2d Update Rust dependencies in sources/

Perhaps the most notable update is nix, since they marked fork unsafe. In reality, it was already unsafe, because fork(2) is unsafe itself in some situations, and nix is a slim wrapper. It makes no practical difference to us other than needing an unsafe { } block - we're only using it to separate thar-be-updates from its parent process, and there's no threading.

actix-web had a major version bump, but not much changed really. Mostly stability improvements and simplification.

Things not updated:

  • tokio 0.3 - hyper hasn't updated yet; you can't use old hyper in new tokio apps, at least not without hacks.
  • gptman - there are big changes that need thought so as to not break our disk handling, but it has the potential to fix our "second" partition resize.
  • tough - the changes in 0.9 are partially undone in 0.10, and it's not worth canceling out the work in tough: update to v0.10.0 #1190, which will handle this update.

Testing done:

  • Unit tests pass
  • apiserver, storewolf, settings-commiter, and apiclient tested locally through settings gets/changes/commits
  • cargo make ami, cargo make repo, cargo make ssm OK
  • Made AMIs for all 6 variants on x86, and aws-k8s-1.17 on aarch64, and confirmed I could run pods/tasks/containers, all boot services were healthy, journal looks OK, API working OK, etc.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@tjkirch tjkirch requested review from bcressey and webern November 5, 2020 23:03
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💸

@tjkirch tjkirch merged commit f7a1496 into bottlerocket-os:develop Nov 6, 2020
@tjkirch tjkirch deleted the rust-deps branch November 6, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants