Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CI failure due to cargo-deny install failure #25

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Conversation

srgothi92
Copy link
Contributor

Issue number:
N/A

Description of changes:
cargo install cargo-deny was failing due to issue in downstream dependency funty and bitvec. cargo-deny issue #331 This change adds --locked to cargo-deny install so exact version specified in Cargo.lock of cargo-deny is used to fetch dependency instead of skipping minor version.

Testing done:
Tested command locally and it works.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Description:
cargo install cargo-deny was failing due to issue in downstream depndency
`funty` and `bitvec`.
cargo-deny issue [#331](EmbarkStudios/cargo-deny#331)
This change adds `--locked` to `cargo-deny` install so exact version specified in
`Cargo.lock` of `cargo-deny` is used to fetch dependency instead of skipping
minor version.
@srgothi92 srgothi92 requested a review from webern February 17, 2021 19:04
@webern
Copy link
Contributor

webern commented Feb 17, 2021

Go ahead and merge it!

@srgothi92 srgothi92 merged commit c75f074 into develop Feb 17, 2021
@srgothi92 srgothi92 deleted the ci-bug branch February 17, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants