Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 tests to ensure dot segments are preserved #3244

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

jonathan343
Copy link
Contributor

Summary

This PR adds s3 specific tests to ensures the following:

  • Leading dot segments in the key value are preserved in the URL path.
    • Example: ../key.txt
  • Embedded dot segments in the key value are preserved in the URL path.
      • Example: foo/../key.txt

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (e0f04ab) to head (22a6383).
Report is 49 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3244   +/-   ##
========================================
  Coverage    93.15%   93.15%           
========================================
  Files           66       66           
  Lines        14287    14287           
========================================
  Hits         13309    13309           
  Misses         978      978           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jonathan343 jonathan343 merged commit 56a36ab into boto:develop Sep 5, 2024
34 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Sep 5, 2024
* release-1.35.13:
  Bumping version to 1.35.13
  Update to latest models
  Add S3 tests to ensure dot segments are preserved (#3244)
hswong3i pushed a commit to alvistack/boto-botocore that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants