-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI for Python >= 3.12 #3223
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3223 +/- ##
========================================
Coverage 93.14% 93.15%
========================================
Files 66 66
Lines 14248 14252 +4
========================================
+ Hits 13272 13276 +4
Misses 976 976 ☔ View full report in Codecov by Sentry. |
Why not install via "pip install -r requirements.txt" ? |
Hey @chemelli74, Because of this change in Python >= 3.12, we conditionally install The issue with installing from |
* release-1.34.146: Bumping version to 1.34.146 Update endpoints model Update to latest models Add changelog Remove deprecated AWS Mobile Hub service Bump aws-actions/closed-issue-message pin setuptools in ci for python >= 3.12 (#3223)
Our CI for Python >= 3.12 has started failing since setuptools-71.0.0 was released on 7/17:
This CR installs
pip install setuptools==67.8.0
before running CI as opposed topip install setuptools
. This matches the following requirement defined inrequirements-dev.txt
and prevents similar issues in the future: