Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Baseclient constructor signature backwards compatible with <1.28.0 #2796

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Make Baseclient constructor signature backwards compatible with <1.28.0 #2796

merged 1 commit into from
Oct 26, 2022

Conversation

jonemo
Copy link
Contributor

@jonemo jonemo commented Oct 26, 2022

#2785 (released in version 1.28.0) introduced a backwards-incompatible change to the signature of the constructor of botocore.client.BaseClient. This change modifies the signature to be backwards-compatible.

@jonemo jonemo requested a review from nateprewitt October 26, 2022 21:30
nateprewitt
nateprewitt approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jonemo!

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022 •
edited
Loading

Codecov Report

Base: 93.57% // Head: 93.59% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (a3bb064) compared to base (72df8fa).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2796      +/-   ##
===========================================
+ Coverage    93.57%   93.59%   +0.02%     
===========================================
  Files           63       63              
  Lines        13300    13300              
===========================================
+ Hits         12445    12448       +3     
+ Misses         855      852       -3
Impacted Files Coverage Δ
botocore/client.py 98.44% <ø> (ø)
botocore/credentials.py 98.96% <0.00%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nateprewitt nateprewitt merged commit d60c2e4 into boto:develop Oct 26, 2022
@jonemo jonemo deleted the base-client-signature branch October 26, 2022 22:56
aws-sdk-python-automation added a commit that referenced this pull request Oct 27, 2022
@aws-sdk-python-automation
Merge branch 'release-1.28.3'
a845209 
* release-1.28.3:
  Bumping version to 1.28.3
  Update to latest endpoints
  Update to latest models
  Support client context params for s3control (#2797)
  Make Baseclient constructor signature backwards compatible with <1.28.0 (#2796)
@ragulpr ragulpr mentioned this pull request Nov 1, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nateprewitt nateprewitt nateprewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonemo @codecov-commenter @nateprewitt