Shutdown IO queue when file can't be opened #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any errors happen while processing IO (including errors opening the destination file), we should shutdown the IO queue. As part of this change I added an integration test. This also demonstrated an issue with python3 retrying socket.errors because they're now aliased to OSErrors. I updated the compat module to give us the appropriate "something went wrong on the socket" exception based on python version. Fixes boto#367.
|
Nice! I wonder if 2to3 does this conversion? Either way: ⛵ |
jamesls
added
the
pr/needs-review
|
Looks good. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any errors happen while processing IO (including
errors opening the destination file), we should shutdown
the IO queue.
As part of this change I added an integration test. This also
demonstrated an issue with python3 retrying socket.errors because
they're now aliased to OSErrors. I updated the compat module
to give us the appropriate "something went wrong on the socket"
exception based on python version.
Fixes #367.
cc @kyleknap @mtdowling @rayluo @JordonPhillips