Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update waiter description #4108

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

tim-finnigan
Copy link
Contributor

Fixes #4107

Replaced "An error is returned" with "An error is raised".

@nateprewitt
Copy link
Contributor

Thanks @tim-finnigan, you'll need to update these two tests as well for your changes:

  • unit/docs/test_docstring.py::TestResourceDocstrings::test_resource_waiter_help
  • unit/docs/test_waiter.py::TestWaiterResourceDocumenter::test_document_resource_waiters

@nateprewitt nateprewitt merged commit b61f7f9 into boto:develop Apr 30, 2024
33 checks passed
aws-sdk-python-automation added a commit that referenced this pull request May 1, 2024
* release-1.34.96:
  Bumping version to 1.34.96
  Add changelog entries from botocore
  Update waiter description (#4108)
hswong3i pushed a commit to alvistack/boto-boto3 that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. waiters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Waiter documentation about error behavior is incorrect
2 participants