feat(indexing)!: Removed duplication of batch_size. Pipeline owns the default ba… #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch size value and Embeed/SparseEmbed are able to modify it. Fixes bosun-ai#233
devsprint
force-pushed
the
batch-size
branch
from
850ac89 to
68b3c26
Compare
timonv
requested changes
Sep 25, 2024
|
fyi #334 relates but it shouldn't interfere |
…ce over pipeline default batch size.
timonv
changed the title
This was referenced Sep 26, 2024
Closed
Merged
timonv
added a commit
that referenced
this pull request
Sep 27, 2024
## 🤖 New release * `swiftide`: 0.12.3 -> 0.13.0 (✓ API compatible changes) * `swiftide-core`: 0.12.3 -> 0.13.0 (✓ API compatible changes) * `swiftide-indexing`: 0.12.3 -> 0.13.0 (⚠️ API breaking changes) * `swiftide-macros`: 0.12.3 -> 0.13.0 * `swiftide-integrations`: 0.12.3 -> 0.13.0 (⚠️ API breaking changes) * `swiftide-query`: 0.12.3 -> 0.13.0 (✓ API compatible changes) ###⚠️ `swiftide-indexing` breaking changes ``` --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/method_parameter_count_changed.ron Failed in: swiftide_indexing::Pipeline::then_in_batch now takes 2 parameters instead of 3, in /tmp/.tmpKWtCli/swiftide/swiftide-indexing/src/pipeline.rs:221 ``` ###⚠️ `swiftide-integrations` breaking changes ``` --- failure enum_marked_non_exhaustive: enum marked #[non_exhaustive] --- Description: A public enum has been marked #[non_exhaustive]. Pattern-matching on it outside of its crate must now include a wildcard pattern like `_`, or it will fail to compile. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/enum_marked_non_exhaustive.ron Failed in: enum SupportedLanguages in /tmp/.tmpKWtCli/swiftide/swiftide-integrations/src/treesitter/supported_languages.rs:37 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/inherent_method_missing.ron Failed in: FastEmbed::with_batch_size, previously in file /tmp/.tmpg5eaNs/swiftide-integrations/src/fastembed/mod.rs:98 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `swiftide` <blockquote> ## [0.13.0](v0.12.3...v0.13.0) - 2024-09-26 ### New features - [7d8a57f](7d8a57f) *(indexing)* [**breaking**] Removed duplication of batch_size ([#336](#336)) **BREAKING CHANGE**: The batch size of batch transformers when indexing is now configured on the batch transformer. If no batch size or default is configured, a configurable default is used from the pipeline. The default batch size is 256. --------- - [fd110c8](fd110c8) *(tree-sitter)* Add support for Java 22 ([#309](#309)) ### Bug fixes - [23b96e0](23b96e0) *(tree-sitter)* [**breaking**] SupportedLanguages are now non-exhaustive ([#331](#331)) **BREAKING CHANGE**: SupportedLanguages are now non-exhaustive. This means that matching on SupportedLanguages will now require a catch-all arm. This change was made to allow for future languages to be added without breaking changes. ### Miscellaneous - [923a8f0](923a8f0) *(fastembed,qdrant)* Better batching defaults ([#334](#334)) ```text Qdrant and FastEmbed now have a default batch size, removing the need to set it manually. The default batch size is 50 and 256 respectively. ``` **Full Changelog**: 0.12.3...0.13.0 </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: Timon Vonk <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233
BREAKING CHANGE: The batch size of batch transformers when indexing is now configured on the batch transformer. If no batch size or default is configured, a configurable default is used from the pipeline. The default batch size is 256.