feat: Major performance improvements #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonv
force-pushed
the
performance-improvements
branch
from
da04e4a to
fcff093
Compare
Merged
timonv
pushed a commit
that referenced
this pull request
Sep 13, 2024
## 🤖 New release * `swiftide`: 0.11.1 -> 0.12.0 * `swiftide-core`: 0.11.1 -> 0.12.0 * `swiftide-indexing`: 0.11.1 -> 0.12.0 * `swiftide-macros`: 0.11.1 -> 0.12.0 * `swiftide-integrations`: 0.11.1 -> 0.12.0 * `swiftide-query`: 0.11.1 -> 0.12.0 <details><summary><i><b>Changelog</b></i></summary><p> ## `swiftide` <blockquote> ## [0.12.0](https://github.com/bosun-ai/swiftide/releases/tag/0.12.0) - 2024-09-13 ### Added - [e902cb7](e902cb7) *(query)* Add support for filters in SimilaritySingleEmbedding ([#298](#298)) - [f158960](f158960) *(uncategorized)* Major performance improvements ([#291](#291)) ### Fixed - [45d8a57](45d8a57) *(ci)* Use llm-cov preview via nightly and improve test coverage ([#289](#289)) - [501dd39](501dd39) *(deps)* Update rust crate redis to 0.27 ([#294](#294)) - [f95f806](f95f806) *(indexing)* Debugging nodes should respect utf8 char boundaries - [f8314cc](f8314cc) *(indexing)* Limit logged chunk to max 100 chars ([#292](#292)) - [9464ca1](9464ca1) *(uncategorized)* Bad embed error propagation ([#293](#293)) - [8595553](8595553) *(uncategorized)* Implement into_stream_boxed for all loaders ### Other - [37c4bd9](37c4bd9) *(deps)* Update treesitter ([#296](#296)) **Full Changelog**: 0.11.1...0.12.0 </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Futures that do not yield were not run in parallel properly. With this futures are spawned on a tokio worker thread by default.
When embedding (fastembed) and storing a 85k row dataset, there's a ~1.35x performance improvement:
Need to do one more test with IO bound futures as well. Pretty huge, not that it was slow.With IO bound openai it's 1.5x.