feat(indexing)!: Use UUIDv3 for indexing node ids #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonv
changed the title
timonv
force-pushed
the
feat/uuid-indexing-nodes
branch
from
bfd52bc to
546a66b
Compare
timonv
pushed a commit
that referenced
this pull request
Sep 6, 2024
## 🤖 New release * `swiftide`: 0.9.2 -> 0.10.0 * `swiftide-core`: 0.9.2 -> 0.10.0 * `swiftide-indexing`: 0.9.2 -> 0.10.0 * `swiftide-macros`: 0.9.2 -> 0.10.0 * `swiftide-integrations`: 0.9.2 -> 0.10.0 * `swiftide-query`: 0.9.2 -> 0.10.0 <details><summary><i><b>Changelog</b></i></summary><p> ## `swiftide` <blockquote> ## [0.10.0](https://github.com/bosun-ai/swiftide/releases/tag/0.10.0) - 2024-09-06 BREAKING CHANGE: Indexing nodes now have their ID calculated using UUIDv3 via MD5 as the previous algorithm was unreliable and broke in 1.81. Added benefit that collision chance is even smaller. This means that when indexing again, nodes will have different IDs and upsert will not work. Backwards compatibility is non-trivial. If this is a huge issue, ping us on discord and we will look into it. ### Added - [57fe4aa](57fe4aa) *(indexing)* Use UUIDv3 for indexing node ids ([#277](#277)) ### Fixed - [5a724df](5a724df) *(uncategorized)* Rust 1.81 support ([#275](#275)) ### Other - [3711f6f](3711f6f) *(readme)* Fix date ([#273](#273)) **Full Changelog**: 0.9.2...0.10.0 </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use UUIDv3 to generate node ids for storage and cache. This is more reliable than the previous u64 hashing, with less chance for collision. Additionally, the previous hash algorithm changes over Rust releases and should not be used.
Closes #272 and needed for proper Rust 1.81 support as in #275
BREAKING CHANGE: All generated ids are now UUIDs, meaning all persisted data needs to be purged or manually updated, as default upserts will fail. There is no backwards compatibility.