Custom errors #821
Merged
Custom errors #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
levalleux-ludo
approved these changes
Nov 21, 2023
albertfolch-redeemeum
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #818
Whenever it makes sense, old string revert reasons were replaced with custom errors, which are more gas-efficient.
Some of the errors are now less verbose than before. The mapping between old errors and new ones can be found by comparing values in
scripts/config/revert-reasons-old.jsand `scripts/config/revert-reasons.jsThere were some inconsistencies in the error naming style, especially with the ones containing the word "invalid". The majority of them had "invalid" as a prefix, while some had it as a suffix. This was now unified, so all have "invalid" at the beginning.
Size change:
