Protocol Initalization Handler Facet documentation #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anajuliabit
suggested changes
Jan 17, 2023
Co-authored-by: Ana Julia Bittencourt <[email protected]>
…boson-protocol-contracts into documentation-initializer
mischat
previously approved these changes
Jan 20, 2023
…boson-protocol-contracts into documentation-initializer
mischat
previously approved these changes
Jan 25, 2023
I will, i didn't know about that feature. I will use it next time, apologies. |
Co-authored-by: Ana Julia Bittencourt <[email protected]>
zajck
added a commit
that referenced
this pull request
Feb 3, 2023
* Initalizer Facet documentation * Apply suggestions from code review Co-authored-by: Ana Julia Bittencourt <[email protected]> * Expand initialization description * Review fixes * upgrade configs * Update docs/tasks.md Co-authored-by: Ana Julia Bittencourt <[email protected]> Co-authored-by: Ana Julia Bittencourt <[email protected]>
zajck
added a commit
that referenced
this pull request
Nov 21, 2023
* 1st iteration * buy order * fulfilSellOrder * releaseFundsToIntermediateSellers * Bump eslint-config-prettier from 8.5.0 to 8.6.0 (#547) Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 8.5.0 to 8.6.0. - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v8.5.0...v8.6.0) --- updated-dependencies: - dependency-name: eslint-config-prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Protocol Initalization Handler Facet documentation (#538) * Initalizer Facet documentation * Apply suggestions from code review Co-authored-by: Ana Julia Bittencourt <[email protected]> * Expand initialization description * Review fixes * upgrade configs * Update docs/tasks.md Co-authored-by: Ana Julia Bittencourt <[email protected]> Co-authored-by: Ana Julia Bittencourt <[email protected]> * chore: add forwarder address in deploy suite script * chore: add forwarder address in .env.example * Rename operator to assistant (#556) * operator->assistant * remove console.log * diagram update * Revert assistant back to operator for ERC721/ERC1155 * PriceDIscovery domain test * sequential commits test, first batch * revert reasons * escrow amount * Return overpaid to buyer * sell order * releaseFunds - COMPLETED * releaseFunds - REVOKED * releaseFunds - CANCELED * releaseFunds - RETRACTED * releaseFunds - DISPUTED - RESOLVED * releaseFunds - ESCALATED * releaseFunds - REFUSED * changing fee + royalties * Refactor * refactor into separate facet * sequentialCommitToOffer tests * verify incoming voucher * Fix failing tests * Protocol Diamond diagram * review fixes * additional tests * remove RoyaltyRecipient + fix typos * Fix typo SequentialCommitHandler.sol * New chunks * correctly toggle preprocessing * SequentialCommitHandlerFacet constructor arg in deployment * fix unit tests * test isEligibleToCommit * review fixes * add events for encumbering/releasing funds * add tests for events for encumbering/releasing funds * use safeerc20 for approval * extend test timeout * Bump code coverage * refactor + disable viaIR compilation * Price discovery (#578) * AMM integration tests (WIP) * Make hardhat task work with submodules which uses foundry * Update hardhat config * Fix diamond deploy * Renaming folders * Continue AMM POC * Add price type to offer struct and continue sudoswap poc * Fix interface ids * Moving lssvm submodule * Make boson voucher compatible with price discovery offers * Continue POC work * Finalize AMM POC * Finalize sudoswap POC * Seaport: Create offer with criteria (WIP) * Seaport: advance order with criteria * Move test files * Fix sudoswap tests * Fix seaport tests * Make commitToOffer and commitToPriceDiscoveryOffer a single method * Price discovery POC: auction * Implement new voucher transfer and protocol communication design (WIP) * Removing logs * Fixing compile * Finish new voucher transfer and protocol communication design * SneakAuction (WIP) * Supports bid commits that requires pre-holding the NFT * Token id is mandatory on bid commits * Continue work on PD * Fix submodules hardhat compilation * Finish refactor * Remove SneakyAuction test and add Zora test * Offer can't be price discovery and be transfer externally at the sime time * Add new validations to fulfilBidOrder * Decoupling bid function * Add natspec comments * Fix set committed * Split commitToOffer and commitToPreMintedOffer * Review changes * Apply more review changes * Owner must be priceDiscoveryContract when caller is not voucher owner * Add some others verifications * Fix Zora integration test without wrapper * Fix stack too deep issue by enabling Yul via iR * Split commitToPriceDiscovery in a new PriceDiscoveryFacet * Add weth to protocol protocol addresses storage * Fix interface ids * Creating SudoswapWrraper * Update SudoswapWrapper contract to allow wrapping multiple tokens at once and modify integration test accordingly * Update SudoswapWrapper contract to allow wrapping by sender * Continue SudoswapWrapper * Finalise sudoswap wrapper poc * Adding missing natspec comments * Upgrade hardhat config and minors changes * Fix pre-minted voucher transfer to check for offer price type and transaction origin * update integration tests * update inegration test - sudoswap * Extend priceDiscovery struct * deprecate commitToPremintedOffer * Fix fundsHandler tests * Fix metaTransactionsHandler tests * Fix Offer domain script * Fix sequentialCommitHandler tests * review fixes 1st iter * Correct resellerId in initial exchangeCosts for price discovery * review fixes 2nd iter * More minore fixes in tests/contracts * PriceDiscoveryHandler unit tests * onPremintedVoucherTransferred test + other minor fixes * Zora wrapper (#598) * initial wrapper * Zora auction PoC * code cleanup, add comments * additional auction tests * Review fixes * Remove ownable * review fixes * wrapper tests * custom mock auction * handling wrapper another type of "Side" * Improve wrapper handling --------- Co-authored-by: zajck <[email protected]> Co-authored-by: Klemen <[email protected]> * New chunks + bump line coverage --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ana Julia Bittencourt <[email protected]> Co-authored-by: Albert Folch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Protocol Initialization Handler Facet is a bit specific, it gets a dedicated page explaining how it works so it can be properly maintained in the future.