Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify succesful upgrade - new actions after upgrade #468

Merged

Conversation

zajck
Copy link
Member

@zajck zajck commented Nov 17, 2022

Continues work from #465

It addresses three points that were not implemented there

  • Verfiy that adding new data after the upgrade does not corrupt the old data
  • Verify that actions that use data from before the upgrade still work as expected
  • Verify breaking changes, i.e. calls that should be broken after the upgrade really behave differently than before the update

@zajck zajck changed the base branch from main to verify-succesful-upgrade November 18, 2022 08:17
@zajck zajck force-pushed the verify-succesful-upgrade-new-actions branch from 3dee0d0 to f41ab91 Compare November 18, 2022 08:25
@zajck zajck marked this pull request as ready for review November 18, 2022 10:56
@zajck zajck self-assigned this Nov 18, 2022
@zajck zajck added the enhancement New feature or request label Nov 18, 2022
test/upgrade/2.0.0-2.1.0.js Outdated Show resolved Hide resolved
test/upgrade/2.0.0-2.1.0.js Outdated Show resolved Hide resolved
test/upgrade/2.0.0-2.1.0.js Outdated Show resolved Hide resolved
test/upgrade/2.0.0-2.1.0.js Show resolved Hide resolved
test/upgrade/2.0.0-2.1.0.js Show resolved Hide resolved
test/upgrade/2.0.0-2.1.0.js Outdated Show resolved Hide resolved
test/upgrade/2.0.0-2.1.0.js Outdated Show resolved Hide resolved
test/upgrade/2.0.0-2.1.0.js Outdated Show resolved Hide resolved
test/upgrade/2.0.0-2.1.0.js Outdated Show resolved Hide resolved
test/upgrade/2.0.0-2.1.0.js Outdated Show resolved Hide resolved
test/upgrade/2.0.0-2.1.0.js Show resolved Hide resolved
@cliffhall cliffhall merged commit 5963f0a into verify-succesful-upgrade Nov 22, 2022
cliffhall added a commit that referenced this pull request Nov 22, 2022
* deploy old, upgrade to new contracts

* create sellers, DRs and agents

* compare state before and after the upgrade

* create and verify offers

* create various exchanges + verify exchanges

* clean up

* all getters

* metaTx private data

* review fixes

* protocolStatus private data

* private protocol lookups - offer related

* private protocol lookups - account related

* private protocol lookups - group related

* private protocol lookups - twins related

* protocol lookpus private data - done

* increase mocha timeout

* tidy

* review changes

* tidy

* Fix typos

* move getMappinStoragePosition to utils

* fix typo

* Verify succesful upgrade - new actions after upgrade (#468)

* populate after upgrade, verify state

* add some bundles

* enable both test + tidy

* commit to old offer

* redeem/revoke/cancel voucher

* update old entities

* second context done

* tidy

* breaking changes

* new methods

* review fixes

Co-authored-by: Cliff Hall <[email protected]>
@zajck zajck deleted the verify-succesful-upgrade-new-actions branch November 23, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants