update eosio.msig contract. #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add new actions: oppose //oppose to current proposal unoppose //undo previous oppose abstain //abstain to current proposal unabstain //undo previous abstain you could only approve or oppose or abstain at a time. ex. if you approved to a proposal,now you wish to oppose it, you need to unapprove first, then you can oppose. oppose and abstain only show attitude, won't affect exec/cancel/invalidate. if you get enough approvals in an proposal, you can exec it, it will ignore the oppose/abstain when doing exec.
Thaipanda
approved these changes
Aug 21, 2019
oldcold
approved these changes
Aug 21, 2019
Merged
vlbos
pushed a commit
to vlbos/bos.contracts
that referenced
this pull request
Nov 26, 2019
version 1.3.1
vlbos
pushed a commit
to vlbos/bos.contracts
that referenced
this pull request
Nov 26, 2019
update eosio.msig contract.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new actions:
oppose //oppose to current proposal
unoppose //undo previous oppose
abstain //abstain to current proposal
unabstain //undo previous abstain
you could only approve or oppose or abstain at a time.
ex. if you approved to a proposal,now you wish to oppose it, you need to unapprove first, then you can oppose.
oppose and abstain only show attitude, won't affect exec/cancel/invalidate.
if you get enough approvals in an proposal, you can exec it, it will ignore the oppose/abstain when doing exec.
update eosio.msig contract.
Change Description
add new actions:
oppose //oppose to current proposal
unoppose //undo previous oppose
abstain //abstain to current proposal
unabstain //undo previous abstain
you could only approve or oppose or abstain at a time.
ex. if you approved to a proposal,now you wish to oppose it, you need to unapprove first, then you can oppose.
oppose and abstain only show attitude, won't affect exec/cancel/invalidate.
if you get enough approvals in an proposal, you can exec it, it will ignore the oppose/abstain when doing exec.
Deployment Changes
need to redeploy eosio.msig contract.
API Changes
add new actions:
oppose //oppose to current proposal
unoppose //undo previous oppose
abstain //abstain to current proposal
unabstain //undo previous abstain
add new multi-index:
name: opposes
struct: {
name proposal_name; //primary key
vector<permission_level> opposed_approvals;
vector<permission_level> abstained_approvals;
}
Documentation Additions