Bugfix/crash on browsing for bad credentials #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krauskopf
requested changes
May 12, 2022
ctrlx-config.js
Outdated
| .finally(() => ctrlx.logOut()); | ||
| .finally(() => { | ||
| // We have to catch, because this fails for bad credentials | ||
| ctrlx.logOut().catch((err) => console.log('Failed to log out with error ' + err.message)); |
There was a problem hiding this comment.
Can you please check if RED.log.warn() would work here? I think, this would be the better option than logging directly to console. But I'm not sure if it works in this context. Also Message "Failed to log out when trying to browse with error" gives more information about what happened.
krauskopf
approved these changes
May 12, 2022
ctrlx-config.js
Outdated
| .finally(() => ctrlx.logOut()); | ||
| .finally(() => { | ||
| // We have to catch, because this fails for bad credentials | ||
| ctrlx.logOut().catch((err) => console.log('Failed to log out with error ' + err.message)); |
There was a problem hiding this comment.
Can you please check if RED.log.warn() would work here? I think, this would be the better option than logging directly to console. But I'm not sure if it works in this context. Also Message "Failed to log out when trying to browse with error" gives more information about what happened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unhandled exception was hard to find.
The branch is missleading and has nothing todo with ipv6 and the crash is 100% reproducable.