Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/random proposals until valid evals #118

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Hotfix/random proposals until valid evals #118

merged 3 commits into from
Dec 19, 2023

Conversation

LGro
Copy link
Member

@LGro LGro commented Aug 3, 2023

If num_initial_random_samples is specified > 0, keep sampling random specifications until num_initial_random_samples many valid evaluations were reported.

@LGro LGro requested review from sfalkner and aeivazi August 3, 2023 14:04
@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited
Loading

Coverage report

The coverage rate went from 90.61% to 90.62% ⬆️
The branch rate is 89%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

blackboxopt/optimizers/botorch_base.py

100% of new lines are covered (82.09% of the complete file).

sfalkner
sfalkner approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@sfalkner sfalkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LGro for making this more consistent.

blackboxopt/optimizers/botorch_base.py Outdated Show resolved Hide resolved
blackboxopt/optimizers/botorch_base.py Outdated Show resolved Hide resolved
tests/optimizers/botorch_base_test.py Show resolved Hide resolved
@LGro
add failing test
a03d957 
Signed-off-by: Grossberger Lukas (CR/AIR2.2) <[email protected]>
@LGro
fix sampling of random specs until enough valid evals reported
fc391bc 
Signed-off-by: Grossberger Lukas (CR/AIR2.2) <[email protected]>
@LGro
simplify num_initial_random check
3986cbd 
Signed-off-by: Grossberger Lukas (CR/AIR2.2) <[email protected]>
@LGro LGro force-pushed the hotfix/random-proposals-until-valid-evals branch from 45464f7 to 3986cbd Compare December 19, 2023 08:53
@LGro LGro merged commit 2dce548 into main Dec 19, 2023
9 checks passed
@LGro LGro deleted the hotfix/random-proposals-until-valid-evals branch December 19, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfalkner sfalkner sfalkner approved these changes

@aeivazi aeivazi Awaiting requested review from aeivazi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LGro @sfalkner