-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add inline rst feature #84
Conversation
Signed-off-by: Markus Braun <[email protected]>
Signed-off-by: Markus Braun <[email protected]>
Signed-off-by: Markus Braun <[email protected]>
… domains. Closes #73 docs: rewritten some parts of the docs and added a syntax guide with rst inline syntax fix(parser): fixed doxygen comment parsing comment parsing was also removing asterisk bulletpoints and other asterisk based formatting. Signed-off-by: Markus Braun <[email protected]>
Signed-off-by: Markus Braun <[email protected]>
Signed-off-by: Markus Braun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thats really a lot of changes and great documentation update. I did not manage to test it. I will do it once I am back from my vacation. Thanks @mb-emag
Signed-off-by: Markus Braun <[email protected]>
Signed-off-by: Markus Braun <[email protected]>
Hello, I came across this PR while trying to understand how to link to an rst-file inside from doxygen while using doxysphinx. Please forward me to the right place if this is not the correct place to ask! :) We are currently undergoing evaluations of possible ways to use doxygen with sphinx. I like to support breathe/exhale as well as doxysphinx for know and decide later which of these will be used. So far it works well side by side and I can get most links to work easily (from rst to doxygen resp. exhale-generated files) but I have troubles doing this with links from doxygen to the rst-documentation. We are using doxysphinx 3.1.0. The following doxygen syntaxes are handled totally different by doxysphinx and breathe/exhale. What is the reason for this totally different behaviour? In a ticket (#73) I read that you had some troubles because of ` and others but in exhale/sphinx they seem to be able to parse it quite good and also support linking with Doxygen source:
Breathe/exhale output:
Doxysphinx output:
Would it be possible to provide a common way of parsing/translating a link? Do I oversee the appropriate solution? |
@Gnomiro Thanks for trying out Doxysphinx.
There is no wrong place to ask questions :) So thats perfectly fine to ask here as long as we get a notification. You could also use the discussions section https://github.com/boschglobal/doxysphinx/discussions if you wish so that the discussions are visible for others as well. @mb-emag will be back next week and he could clarify this issue. |
Hi @Gnomiro, The problem here is that breathe and exhale parses doxygen xml output and renders then the classes functions etc. on its own. Doxysphinx on the other hand parses doxygen's html output - this keeps the doxygen look and is faster. However that means that doxygen has already parsed the comments and has build up an html structure out of the comments. So e.g. backticks will be interpreted as markdown verbatim content by doxygen and rendered as One reason while we developed doxysphinx was the performance which isn't that good with breathe/exhale on very huge projects. Doing such a pattern matching over the complete html content will bring a hard performance hit (because we would need to pattern match the html tree and rewrite it in a preprocessing step). So I fear that we will never be able to support breathe's inline syntax. @twodrops we can talk about this topic in our next technical sync (next month) - I think this is really a hard problem but it might be worth the (for sure) hard work there. I created a feature request for that topic #87 to better keep track of it. |
Ok. Thanks for the information :) If there is no easy way for having a two-way solution at the moment we will probably just use doxysphinx. But for an easier switch it would probably be great to provide a way for easier migration like suggested in the future request you created. |
Finally the first working implementation of the rst inline feature (which was way harder to implement than i initially thought)