[tr064] fix comment in SOAP request (openhab#9671)

* fix comment in SAOP request * fix typo in channel-name Signed-off-by: Jan N. Klug <[email protected]>
bosch-io · Jan 3, 2021 · ed92bd9 · ed92bd9
1 parent 3f85658
commit ed92bd9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...org.openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/util/Util.java b/...org.openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/util/Util.java
@@ -219,7 +219,8 @@ public static void checkAvailableChannels(Thing thing, ThingBuilder thingBuilder
                             parameters.forEach(parameter -> {
                                 // remove comment: split parameter at '#', discard everything after that and remove
                                 // trailing spaces
-                                String normalizedParameter = UIDUtils.encode(parameter.split("#")[0].trim());
+                                String rawParameter = parameter.split("#")[0].trim();
+                                String normalizedParameter = UIDUtils.encode(rawParameter);
                                 ChannelUID channelUID = new ChannelUID(thing.getUID(),
                                         channelId + "_" + normalizedParameter);
                                 ChannelBuilder channelBuilder = ChannelBuilder
@@ -228,7 +229,7 @@ public static void checkAvailableChannels(Thing thing, ThingBuilder thingBuilder
                                         .withLabel(channelTypeDescription.getLabel() + " " + parameter);
                                 thingBuilder.withChannel(channelBuilder.build());
                                 Tr064ChannelConfig channelConfig1 = new Tr064ChannelConfig(channelConfig);
-                                channelConfig1.setParameter(parameter);
+                                channelConfig1.setParameter(rawParameter);
                                 channels.put(channelUID, channelConfig1);
                             });
                         }

diff --git a/bundles/org.openhab.binding.tr064/src/main/resources/channels.xml b/bundles/org.openhab.binding.tr064/src/main/resources/channels.xml
@@ -236,7 +236,7 @@
 			serviceId="urn:WANDSLIfConfig-com:serviceId:WANDSLInterfaceConfig1"/>
 		<getAction name="GetInfo" argument="NewDownstreamAttenuation"/>
 	</channel>
-	<channel name="dslUpstreamAttentuation" label="DSL Upstream Attenuation">
+	<channel name="dslUpstreamAttenuation" label="DSL Upstream Attenuation">
 		<item type="Number:Dimensionless" unit="dB" statePattern="%.1f dB"/>
 		<service deviceType="urn:dslforum-org:device:WANDevice:1"
 			serviceId="urn:WANDSLIfConfig-com:serviceId:WANDSLInterfaceConfig1"/>