Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LevelFormatter docs and add tests for formatting string. #85

Closed
wants to merge 1 commit into from

Conversation

jkulhanek
Copy link

In this PR the fix for #84 is implemented with tests.

@borntyping
Copy link
Owner

This looks great, though has broken tests on Python 2:

py27-test run-test: commands[0] | py.test -v colorlog
ImportError while loading conftest '/.../borntyping/python-colorlog/colorlog/tests/conftest.py'.
  File "/.../borntyping/python-colorlog/colorlog/tests/conftest.py", line 74
    def function(*args, lines=None, **kwargs):
                            ^
SyntaxError: invalid syntax
ERROR: InvocationError for command /.../borntyping/python-colorlog/.tox/py27-test/bin/py.test -v colorlog (exited with code 4)

(Sorry, at some point automated tests for this repository have broken. Tests can be run with Tox, though need various versions of Python installed.)

@borntyping borntyping force-pushed the master branch 4 times, most recently from 7ddb979 to 86da30b Compare November 9, 2020 10:14
@borntyping borntyping added this to the v6.0.0 milestone Apr 13, 2021
@borntyping
Copy link
Owner

Tests that this works as expected have been added in 6.0.0a2.

(This is a prerelease and may change before version 6.0.0.)

@borntyping borntyping closed this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants